fix: RundownView shows spinner when unMOSing a Rundown from a Playlist (SOFIE-3539) #1311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release51 #1311 +/- ##
=============================================
+ Coverage 57.90% 58.09% +0.18%
=============================================
Files 526 525 -1
Lines 84973 85094 +121
Branches 4394 4599 +205
=============================================
+ Hits 49207 49432 +225
+ Misses 35740 35631 -109
- Partials 26 31 +5 ☔ View full report in Codecov by Sentry. |
nytamin
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a:
Bug fix
Current Behavior
The RundownView will show a spinner when removing a Rundown from a Playlist, e.g. via MOS active
New Behavior
The RundownView should now be stable, however the ShowStyleVariants publication ready state may not be accurate.
Testing
Affected areas
Time Frame
This Bug Fix is critical for us, please review and merge it as soon as possible.
Other Information
Status